Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: e2e: ensure decrypt button is displayed #12315

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: e2e: ensure decrypt button is displayed #12315

wants to merge 2 commits into from
+1 −0

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Nov 16, 2024 •
edited
Loading

Description

Fix a flaky test that seems to be failing to tap Decrypt button by adding another scrollToDecrypt().

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Flaky test run: https://app.bitrise.io/build/5b4ae852-dbbc-4014-91f9-b439c01e4243?tab=tests

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bd283ed
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9192de96-1fbb-4e77-aae2-e22ab6c5b506

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.41%. Comparing base (22a4989) to head (c89f696).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #12315   +/-   ##
=======================================
  Coverage   56.41%   56.41%           
=======================================
  Files        1797     1798    +1     
  Lines       40586    40615   +29     
  Branches     5097     5100    +3     
=======================================
+ Hits        22896    22913   +17     
- Misses      16134    16140    +6     
- Partials     1556     1562    +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisleewilcox @codecov-commenter @metamaskbot